Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image_example.py, use foxglove-schemas-protobuf package #814

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

jhurliman
Copy link
Contributor

Public-Facing Changes

  • [Python] New image_example.py for writing RawImage, CameraCalibration, and ImageAnnotation
  • [Python] Use foxglove-schemas-protobuf package instead of in-repo proto/pb2 files

@jhurliman
Copy link
Contributor Author

jhurliman commented Feb 16, 2023

pipenv run black --check --diff --color mcap
Traceback (most recent call last):
  File "/home/runner/.local/share/virtualenvs/python--WAQ1xVa/bin/black", line 5, in <module>
    from black import patched_main
  File "src/black/__init__.py", line 45, in <module>
  File "/home/runner/.local/share/virtualenvs/python--WAQ1xVa/lib/python3.10/site-packages/black/files.py", line 34, in <module>
    import tomli as tomllib
ModuleNotFoundError: No module named 'tomli'
make: *** [Makefile:42: lint] Error 1

How did this happen

@jtbandes
Copy link
Member

It looks like the tomli issue was fixed in psf/black#3447 Maybe we can upgrade black to avoid this?

@jhurliman
Copy link
Contributor Author

@jtbandes this PR already upgrades black to the latest version. It turned out to be a setuptools issued, which was fixed by upgrading the pipenv version we use in CI.

@jhurliman jhurliman enabled auto-merge (squash) February 16, 2023 22:51
@jhurliman jhurliman merged commit ae2cad0 into main Feb 16, 2023
@jhurliman jhurliman deleted the jhurliman/foxglove-schemas-protobuf branch February 16, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants